Discussion:
[Rcpp-devel] return Colvec as vector
Sokol Serguei
2017-07-29 08:47:14 UTC
Permalink
Dirk Eddelbuettel has written at Fri, 28 Jul 2017 17:28:11 -0500
| > Don't think so, but I have thought about it too, and I was planning to bring
| > this up. I also find the 'always forced to be dimension one matrix' to be a
| > (very early) design decision I would not make again. And I have been
| > thinking along similar lines---we need an option to restore it / keep it as
| > the defaults, and a newer alternative to let this collapse to a dimless
| > vector. What you rprose could work (maybe by prefixing RCPP_ARMADILLO_ to
| > the #define though).
| RCPP_ARMADILLO_RETURN_COLVEC_AS_VECTOR
| RCPP_ARMADILLO_RETURN_ROWVEC_AS_VECTOR
| RCPP_ARMADILLO_RETURN_ANYVEC_AS_VECTOR
Thumbs up!
Do you want to sketch a pull request, or shall we take this offline?
A pull request #151 is awaiting your exam.

Serguei.
Dirk Eddelbuettel
2017-07-29 13:20:14 UTC
Permalink
On 29 July 2017 at 01:47, Sokol Serguei wrote:
| Dirk Eddelbuettel has written at Fri, 28 Jul 2017 17:28:11 -0500
| > On 28 July 2017 at 14:59, Serguei Sokol wrote:
| > | Le 28/07/2017 à 13:45, Dirk Eddelbuettel a écrit :
| > | > Don't think so, but I have thought about it too, and I was planning to bring
| > | > this up. I also find the 'always forced to be dimension one matrix' to be a
| > | > (very early) design decision I would not make again. And I have been
| > | > thinking along similar lines---we need an option to restore it / keep it as
| > | > the defaults, and a newer alternative to let this collapse to a dimless
| > | > vector. What you rprose could work (maybe by prefixing RCPP_ARMADILLO_ to
| > | > the #define though).
| > | Cool. Then to be complete, we can think about a full set of options, smth. like:
| > | RCPP_ARMADILLO_RETURN_COLVEC_AS_VECTOR
| > | RCPP_ARMADILLO_RETURN_ROWVEC_AS_VECTOR
| > | RCPP_ARMADILLO_RETURN_ANYVEC_AS_VECTOR
| >
| > Thumbs up!
| >
| > Do you want to sketch a pull request, or shall we take this offline?
| A pull request #151 is awaiting your exam.

Thanks for getting it started. It is a little bare as it stands right now but
we can get there.

If other wants to chime in: https://github.com/RcppCore/RcppArmadillo/pull/151

Dirk
--
http://dirk.eddelbuettel.com | @eddelbuettel | ***@debian.org
Dirk Eddelbuettel
2017-08-02 18:29:45 UTC
Permalink
On 1 August 2017 at 18:54, Sokol Serguei wrote:
| > If other wants to chime in: https://github.com/RcppCore/RcppArmadillo/pull/151
| ... and now with unit tests and comments in RcppArmadilloConfig.h:
| https://github.com/RcppCore/RcppArmadillo/pull/154

And #151 and #154 are now in the master branch, along with an upgrade to
Armadillo 7.960.0.

I'll probably cut a new RcppArmadillo release "soon".

Dirk
--
http://dirk.eddelbuettel.com | @eddelbuettel | ***@debian.org
Loading...